Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Plurality enum #234

Closed
MehdiK opened this issue Apr 19, 2014 · 1 comment
Closed

Remove Plurality enum #234

MehdiK opened this issue Apr 19, 2014 · 1 comment
Milestone
V2

Comments

@MehdiK
Copy link
Member

MehdiK commented Apr 19, 2014

Plurality enum is only used with Singularize and Pluralize methods and as discussed in #198 is a bit confusing and redundant. We could replace it with a boolean param (e.g. inputIsSingular and inputIsPlural) to clean up the API and remove the unnecessary enum.
@MehdiK MehdiK added this to the V2 milestone Apr 19, 2014
@MehdiK MehdiK mentioned this issue Apr 19, 2014
Closed
@MehdiK MehdiK mentioned this issue May 9, 2014
Merged
@mexx mexx mentioned this issue Jun 24, 2014
Merged
@MehdiK
Copy link
Member Author

MehdiK commented Jun 27, 2014

This is covered in #306. We will remove all the obsolete bits on V2.

@MehdiK MehdiK closed this as completed Jun 27, 2014
@clairernovotny clairernovotny mentioned this issue Dec 18, 2015
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2
Development

No branches or pull requests
1 participant
@MehdiK