-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #518 #519
Fixes #518 #519
Conversation
@i3arnon Thank you for your contribution. Please update the readme.md, I think it's worth adding a new section like the |
fixes #518 |
I think we need to mark these methods with |
Also, I concern about "billions". In a "real world" there are "long scale" and "short scale". We need to describe explicitly in XML comments what scale do we use (it's short) |
63ab0ed
to
f59c8ca
Compare
LGTM |
Rebased and merged in, thanks! |
This change is