Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #518 #519

Closed
wants to merge 5 commits into from
Closed

Fixes #518 #519

wants to merge 5 commits into from

Conversation

i3arnon
Copy link
Contributor

@i3arnon i3arnon commented Jan 30, 2016

This change is Reviewable

@mexx
Copy link
Collaborator

mexx commented Jan 31, 2016

@i3arnon Thank you for your contribution.

Please update the readme.md, I think it's worth adding a new section like the Fluent Date one.

@mexx
Copy link
Collaborator

mexx commented Jan 31, 2016

fixes #518
GitHub doesn't link the PR and the issue when it's in title, it has to be in comment.

@mexx mexx mentioned this pull request Jan 31, 2016
@hazzik
Copy link
Member

hazzik commented Feb 4, 2016

I think we need to mark these methods with [MethodImpl(MethodImplOptions.AggressiveInlining)]

@hazzik
Copy link
Member

hazzik commented Feb 4, 2016

Also, I concern about "billions". In a "real world" there are "long scale" and "short scale". We need to describe explicitly in XML comments what scale do we use (it's short)

@clairernovotny
Copy link
Member

clairernovotny commented May 1, 2016

Pinging @mexx @hazzik? Should this be merged?

@aloisdg
Copy link
Contributor

aloisdg commented Jun 27, 2016

Any update on this? @i3arnon @mexx @hazzik

@mexx
Copy link
Collaborator

mexx commented Jun 27, 2016

LGTM

@aloisdg aloisdg mentioned this pull request Jun 27, 2016
5 tasks
@clairernovotny
Copy link
Member

Rebased and merged in, thanks!

@i3arnon i3arnon deleted the NumberToNumber branch July 3, 2016 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants