Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToQuantity ShowQuantityAs.Words fails on Arabic culture #91

Closed
faisalr opened this issue Feb 14, 2014 · 3 comments
Closed

ToQuantity ShowQuantityAs.Words fails on Arabic culture #91

faisalr opened this issue Feb 14, 2014 · 3 comments

Comments

@faisalr
Copy link
Contributor

faisalr commented Feb 14, 2014

It gives صفر cases instead of zero cases and واحد case instead of one case ?

There is 15 other test fail, namely ToOrdinalWords and DateHumanizeTests.

ToOrdinalWords صفرth is wrong and does not exist in Arabic ?

Only happen on my computer because my windows region and language is set to Arabic.

@MehdiK
Copy link
Member

MehdiK commented Feb 15, 2014

Good catch.

This method is not localized yet; but since it uses ToWords behind the scene and that has an implementation for Arabic this is happening. For now we should enforce ToQuantity to use English culture by wrapping the call in a try-finally statement catching the UICulture, setting it to English and reverting back at the end. If we decide to localize this method we can then think of a way to fix that too.

@MehdiK
Copy link
Member

MehdiK commented Apr 6, 2014

Hey, do you think you could implement a ToQuantity for Arabic like the way ToWords works? I think there is enough difference between the two languages that one cannot reuse much logic, right?

@MehdiK
Copy link
Member

MehdiK commented Apr 7, 2014

Superseded by #132.

@MehdiK MehdiK closed this as completed Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants