-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The version check conflicts with shell-config
#332
Comments
Great comments, thanks a lot for the stacktrace. |
Should be fixed with #334 |
Quick work, thank you for all your hard work! For the record, I may have figured out why the json wasn't parsing. I might have hit the max open file limit with some podman containers because Alacritty started giving me:
Or maybe not, who knows 🤷 |
The parsing error was due to my incompetence in not making sure that trove.yml files still open with the latest state of |
Warnings in
shell-config
On my system:
hoard shell-config -s fish 2>/dev/null
Returns the following:
These warnings should atleast print to
STDERR
so it can be added to the~/.config/fish/config.fish
like so:Crash During Version Check
I kept hitting this
.unwrap
, I'm not sure why though:I appreciate that it should parse the json and I'm not able to reproduce this, but it's happened a couple times. Here is the stack trace:
Click Me
We could refactor the code to avoid the unwrap, because a version check really shouldn't crash the program:
The text was updated successfully, but these errors were encountered: