Enhance alias logs function #89 #62 #90
Conversation
* alias logs will now pull the latest version logs from “Lambda” service directly if --version flag is not specificed. * Added --version flag to alias logs, so that user can view logs of a specific version of function.
There was a problem hiding this comment.
Hey @rklhui . Thanks for the PR and your work 👍 .
I have marked some changes that need to be done. Additionally, after that, the unit tests have to be adapted and extended to test for the new option and error message.
Please let me know, if you need any help there.
lib/logs.js
Outdated
| @@ -124,6 +125,10 @@ module.exports = { | |||
| }, | |||
|
|
|||
| functionLogsShowLogs(logStreamNames) { | |||
| if (logStreamNames.length === 0) { | |||
There was a problem hiding this comment.
Use lodash's _.isEmpty(logStreamNames) here. This will also work for cases where logStreamNames might be nil.
lib/logs.js
Outdated
| let aliasGetAliasFunctionVersion | ||
| // Check if --version is specified | ||
| if (this._options.version) { | ||
| aliasGetAliasFunctionVersion = BbPromise.resolve(this._options.version) |
There was a problem hiding this comment.
There are some missing semicolons. Please check the Travis build (https://travis-ci.org/HyperBrain/serverless-aws-alias/builds/325347600) for details.
lib/stackInformation.js
Outdated
| this._options.stage, | ||
| this._options.region) | ||
| .then(result => { | ||
| return result.FunctionVersion |
There was a problem hiding this comment.
You can use the short form here:
.then(result => _.get(result, 'FunctionVersion', null));
With lodash that will also cover all cases where result might be invalid and returns a reasonable default.
Of course the result should then be checked at the caller (above).
added missing semicolon use lodash to avoid errors
updated test cases for logs to match the enhancement
|
Thanks @HyperBrain, I have problem passing the test case for #updateAlias(), as I ran the test locally and seems to have no problem. Please have a look. |
|
@rklhui I will have a look |
Enhance alias logs function serverless-heaven#89 serverless-heaven#62
service directly if --version flag is not specificed.
specific version of function.
Closes #89
Closes #62