Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Basic Auth support broken - loses casing #326

Closed
t3chguy opened this issue Apr 12, 2021 · 1 comment
Closed

HTTP Basic Auth support broken - loses casing #326

t3chguy opened this issue Apr 12, 2021 · 1 comment
Milestone
3.0

Comments

@t3chguy
Copy link

t3chguy commented Apr 12, 2021

The username gets lowercased against the spec

https://tools.ietf.org/html/rfc7617#section-2.1
https://tools.ietf.org/html/rfc7613#section-3.3

Case-Mapping Rule: Uppercase and titlecase characters MUST NOT be
mapped to their lowercase equivalents; see further discussion in
Section 3.4.

See element-hq/element-web#16825 for more details

Reproduction:

https://soapbox.github.io/linkifyjs/

Enter https://Foo:Bar@Test.com/FooBar and linkify, the link points to https://foo:Bar@test.com/FooBar and breaks the auth.
@t3chguy t3chguy mentioned this issue Apr 12, 2021
Closed
@nfrasser nfrasser added this to the 3.0 milestone Apr 12, 2021
@nfrasser
Copy link
Owner

Fixed in v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@nfrasser @t3chguy