Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant access to edit a document to a user #7

Closed
MCtzr opened this issue Feb 28, 2023 · 17 comments
Closed

Grant access to edit a document to a user #7

MCtzr opened this issue Feb 28, 2023 · 17 comments
Labels

Comments

@MCtzr
Copy link
Contributor

MCtzr commented Feb 28, 2023

Description : Permit the user to only modify his documents and the links inside only. Then permit the author to transmit his rights to a viewer.

Acceptance criteria : By default, the author is the only user capable to modify his document and its references inside. The author is also capable to give some rights to a viewer.

@StachoB
Copy link
Contributor

StachoB commented Feb 28, 2023

Respecte tous les principes INVEST, peut être reformulé en tant que : Give access to edit a document to a user

@MCtzr MCtzr changed the title Give access hierarchy for Authors Give access to edit a document to a user Mar 1, 2023
@RomainUTT
Copy link
Contributor

This ticket respects the principle of the INVEST method

@benel benel added the feature label Mar 14, 2023
@benel
Copy link
Member

benel commented Mar 14, 2023

@MCtzr You could (or should?) rephrase the title with the verb "grant" (the sentence structure however is a bit different).

@MCtzr MCtzr changed the title Give access to edit a document to a user Grant access to edit a document to a user Mar 14, 2023
@MCtzr
Copy link
Contributor Author

MCtzr commented Mar 16, 2023

Histoire de l'art : Ce Ticket est une suggestion. Si par exemple on décide de prendre des features d'ajout ou de suppression de references d'un document (cf #2 et #3), il sera surement nécessaire de mettre en place une gestion des droits d'accès des utilisateurs.

@benel benel self-assigned this Apr 9, 2023
@benel benel removed their assignment Jan 8, 2024
@Anto792
Copy link
Contributor

Anto792 commented Mar 12, 2024

Traduction : this ticket can be useful in the futur. It can be participate of the student/teacher participation in hyperglosae.

@AgatheIV
Copy link
Contributor

Cela permettrait de choisir les utilisateurs qui pourraient apporter des éléments pertinents aux documents

@nitram35
Copy link
Contributor

nitram35 commented Mar 13, 2024

Cela faciliterait le travail collaboratif (dans le cas d'IF14 en binôme) en permettant à d'autres utilisateurs d'apporter de nouveaux éléments

@Anto792
Copy link
Contributor

Anto792 commented Mar 19, 2024

@nitram35
Copy link
Contributor

nitram35 commented Apr 10, 2024

Phase 1

  • Scenarios (Gherkin)
  • Mockups
  • Implementation strategy

Phase 2

  • Acceptance tests (Capybara)
  • Implementation

Phase 3

  • Screencast

@nitram35
Copy link
Contributor

nitram35 commented Apr 10, 2024

Image
Image

@Hypertopic Hypertopic deleted a comment from petitfa1 Apr 10, 2024
@benel
Copy link
Member

benel commented Apr 17, 2024

Thank you very much for your mockup. Was it peer work or single person work?

  1. Auto-completion could probably moved to an another ticket. Because:
    • There are a lot of design decisions to take (related to GDPR, projects, teams, etc.) and then a lot of cases to test.
    • This feature can work without it (think about INVEST criteria).
  2. Instead, it seems absolutely necessary to know who is already an editor. This is the minimum feedback and context awareness clues you need.

@petitfa1
Copy link
Contributor

Image

@petitfa1
Copy link
Contributor

petitfa1 commented Apr 17, 2024

Implementation Strategy:

  • Test ajout éditeur avec Postman (droit d'accès)
  • bouton et document graphique avec Bootstrap (satisfait les requirements)
  • formater le nom d'utilisateur pour eviter les espaces

partie du code sera impactée (classes, méthodes) : Création d'une nouvelle classe more.js : composant du menu (+ action d'ajouter l'utilisateur avec la modale)
ajout de ce composant dans lectern.js dans le running head margin

Pas de difficulté patriculière algorithmiquement
Pas de récupération de donnée, more.js ajoute l'utilisateur en tant qu'éditeur en base

@benel benel linked a pull request Apr 26, 2024 that will close this issue
@Barnabepetit
Copy link
Contributor

Image

Image

Image

Barnabepetit added a commit that referenced this issue Jun 7, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com>
Barnabepetit added a commit that referenced this issue Jun 7, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com>
@Barnabepetit
Copy link
Contributor

Screencast.Grant.access.mp4

louisduhalberruer added a commit that referenced this issue Jun 7, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com>
louisduhalberruer added a commit that referenced this issue Jun 7, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com>
louisduhalberruer added a commit that referenced this issue Jun 7, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com>
louisduhalberruer added a commit that referenced this issue Jun 7, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com>
louisduhalberruer added a commit that referenced this issue Jun 7, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com>
louisduhalberruer added a commit that referenced this issue Jun 7, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Co-Authored-By: Barnabepetit <160789624+Barnabepetit@users.noreply.github.com>
Barnabepetit added a commit that referenced this issue Jun 12, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Barnabepetit added a commit that referenced this issue Jun 12, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
Barnabepetit added a commit that referenced this issue Jun 12, 2024
Co-Authored-By: Louis Duhal Berruer <19203540+louisduhalberruer@users.noreply.github.com>
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
@Barnabepetit
Copy link
Contributor

Barnabepetit commented Jun 12, 2024

@raphaelweis collaborated as an expert on the scenarios in this ticket.

@benel
Copy link
Member

benel commented Jun 27, 2024

Good evening @Barnabepetit!
Who was your peer when creating the screencast?
Or were you on your own?

benel pushed a commit that referenced this issue Jul 10, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
benel pushed a commit that referenced this issue Jul 10, 2024
Co-Authored-By: petitfa1 <115662302+petitfa1@users.noreply.github.com>
@benel benel closed this as completed in 3a514d3 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

9 participants