Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT MapSegmentationCapability parses 'set' value differently than the capability router #889

Closed
ccoors opened this issue May 2, 2021 · 0 comments · Fixed by #891
Closed

MQTT MapSegmentationCapability parses 'set' value differently than the capability router #889

ccoors opened this issue May 2, 2021 · 0 comments · Fixed by #891
Labels
bug Something isn't working

Comments

@ccoors
Copy link
Contributor

ccoors commented May 2, 2021

Ping @depau

Describe the bug

Setting <TOPIC PREFIX>/<IDENTIFIER>/MapSegmentationCapability/clean/set via MQTT with the segment IDs as strings does not work.

To Reproduce

  1. Get the ID mapping from map-data
  2. Try to use the IDs as they are provided (as strings)
  3. Valetudo does not recognize them.

Screenshots

photo_2021-05-02_10-39-07

Vacuum Model

Roborock S50

Valetudo Version

master (f2e2a87)

Expected behavior

The IDs get parsed to ints before they are passed to this.capability.executeSegmentAction in MapSegmentationCapabilityMqttHandle.js.
@ccoors ccoors added the bug Something isn't working label May 2, 2021
depau added a commit to depau-forks/Valetudo that referenced this issue May 3, 2021
@depau
fix(mqtt): Allow strings as segment IDs
e5554b2 
Fixes Hypfer#889
@depau depau mentioned this issue May 3, 2021
Merged
5 tasks
Hypfer pushed a commit that referenced this issue May 3, 2021
@depau
fix(mqtt): Allow strings as segment IDs (#891)
3e30414 
Fixes #889
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mqtt): Allow strings as segment IDs depau-forks/Valetudo
1 participant
@ccoors