-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add investments table and partners page #2126
Conversation
hypha/public/partner/models.py
Outdated
) | ||
|
||
created_at = models.DateTimeField(auto_now_add=True) | ||
updated_at = models.DateTimeField(auto_now_add=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated_at = models.DateTimeField(auto_now_add=True) | |
updated_at = models.DateTimeField(auto_now=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first step. @frjo Can we deploy this branch to the testing environment, to get feedback from Dan? It will help to get more inputs about the requirements.
Deploying this to test now. |
Redeployed latest changes to test. |
Thanks @frjo. One thing that we need to discuss is the requirements of Other than that, we can add search/filter and other functionalities later on when the dataset grows. |
This is great. Feedback here: ResetNetwork#79 (comment) |
41c2154
to
159864d
Compare
@frjo, can we redeploy this to test. |
@sks444 Deployed to test now. |
159864d
to
ff2709a
Compare
ff2709a
to
f312176
Compare
f312176
to
509b02f
Compare
@sks444 Redeployed to test now. |
Thanks @frjo. It looks like the data entry created from the old migration is still there in the cms. https://test-apply.opentech.fund/admin/pages/17/ (Our Partners). Now I can not delete/edit/add as it will raise 500. This problem I have been noticing in wagtail from quite some time now. Pages are cached and remain there even if we unapply the corresponding migrations. So the process is to first delete the pages from wagtail and then unapply the migrations. @frjo, can we do the following: We need to delete current
|
@sks444 Done, hope I managed to fix it. |
Thank you so much for the effort @frjo. I still see Can you try once again to delete that when you're on other branch where partners code is not deployed. And then redeploy the partners branch. This is cached page I believe. So will have to delete it from where the current branch code is not deployed. And then redeploy the current branch. Let me know if that doesn't work out. I am also not 100% sure on this, I just do this fix when I face similar kind of problem locally sometime. |
@sks444 Now that page is gone as well. |
509b02f
to
fb8eeef
Compare
Codecov Report
@@ Coverage Diff @@
## main #2126 +/- ##
==========================================
- Coverage 82.11% 81.84% -0.27%
==========================================
Files 607 614 +7
Lines 21849 22126 +277
==========================================
+ Hits 17942 18110 +168
- Misses 3907 4016 +109
Continue to review full report at Codecov.
|
Fixes ResetNetwork#79
Steps to test this feature:
About
page. (similar to Person Index Page)Investments
and create Investments for partners that you created.about
tab. You'll get a table of all partners with their investments made.TODOs:
-- type: Can we use the Category Question "Organization Type"?