Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed registration form, cleaned up login flow #3821

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Removed registration form, cleaned up login flow #3821

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6d962f
Removed the registration form, cleaned up login flow
wes-otf Mar 19, 2024
a093d31
Added conditionals for `ENABLE_PUBLIC_SIGNUP`, added more translation…
wes-otf Mar 20, 2024
f96cb89
Ignored media query line stylelint
wes-otf Mar 20, 2024
7d558d8
Use Sign in everywhere, not register.
frjo Mar 21, 2024
146dc95
Log in without password button.
frjo Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hypha/templates/includes/passwordless_login_button.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
href="{% url 'users:passwordless_login_signup' %}{% if next %}?next={{next}}{% endif %}"
>
{% heroicon_mini "envelope" size=18 class="inline align-text-bottom me-1" aria_hidden=true %}
{% trans "Log in " %}{% if ENABLE_PUBLIC_SIGNUP %} {% trans "or" %} {% trans "Sign in" %}{% endif %} {% trans "via" %} {% trans "e-mail" %}
{% trans "Log in without password" %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot better, should we indicate that this is where you would also go to signup though as that isn't given anywhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if enabled)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was that if you clicked your way to the password login form you are most likely not needing to create an account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough, all good by me!

</a>
Loading