Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task is not removed for staff while project moved to next stage #4026

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

sandeepsajan0
Copy link
Member

Fixes #3946

Test Steps

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jul 3, 2024
@wes-otf wes-otf added Status: Tested - changes/discussion needed 🔨 and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jul 11, 2024
@wes-otf
Copy link
Contributor

wes-otf commented Jul 11, 2024

Hey @sandeepsajan0 I don't think the tasks show up in my task list anymore - I just create a new project and make sure the fund has a valid Project Form set & I'm the lead right?

@sandeepsajan0
Copy link
Member Author

@wes-otf Sorry for the late response, I missed it somehow.

I just create a new project and make sure the fund has a valid Project Form set & I'm the lead right?

Project creation creates a task for all staff members(exact) and I think your account might have other roles like staff admin, try/check it with any staff account. Ideally, only staff members will be dealing as project leads and we have some hard/exact role checks in project side because of PAF reviewer roles.

@wes-otf
Copy link
Contributor

wes-otf commented Aug 7, 2024

@sandeepsajan0 this worked for me! my only thoughts are that only staff that are leads on a project should have it appear in their task list. At least with how many projects OTF has I could see it bogging down the tasks lists. @frjo @Techslammer any thoughts?

@frjo
Copy link
Contributor

frjo commented Aug 8, 2024

@wes-otf If OTF want to change who gets the task I think a new issue is the place for that.

If this PR removes the task as it should we might approve it.

@wes-otf
Copy link
Contributor

wes-otf commented Aug 8, 2024

that sounds good to me! I'll open another issue

@frjo frjo merged commit f61e3ce into main Aug 8, 2024
10 checks passed
@frjo frjo added Type: Bug Bugs! Things that are broken :-/ and removed Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). labels Aug 8, 2024
@frjo frjo changed the title Fix: Task is not removed for staff while project moved to next stage Task is not removed for staff while project moved to next stage Aug 8, 2024
theskumar added a commit that referenced this pull request Aug 9, 2024
* origin/main:
  Notification upon profile update (#3970)
  Fix error in View All when no reviewer role image (#4068)
  Remove tasks from task list (#4040)
  Update modals to use htmx/alpine (#4053)
  Fix: Task is not removed for staff while project moved to next stage (#4026)
  Speed & appearance improvements to the results page (#4043)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Tested - approved for live ✅ Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When Project Form is submitted by someone that isn't the lead, to do notification stays in lead's todo
3 participants