Make sampled_from() non-lazy
#2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
immediate-sample
branch
3 times, most recently
from
2e9b797
to
22c5fbe
Compare
DRMacIver
reviewed
Jul 27, 2020
hypothesis-python/src/hypothesis/strategies/_internal/strategies.py
Outdated
Show resolved
Hide resolved
DRMacIver
reviewed
Jul 27, 2020
|
OK, I think that's done now 🙂 |
DRMacIver
approved these changes
Jul 27, 2020
| @@ -191,12 +191,18 @@ def cached_strategy(*args, **kwargs): | |||
| return cached_strategy | |||
|
|
|||
|
|
|||
| def base_defines_strategy(force_reusable: bool) -> Callable[[T], T]: | |||
| def base_defines_strategy( | |||
| force_reusable: bool, *, try_non_lazy: bool = False | |||
There was a problem hiding this comment.
No need to do this as part of this pull request, but maybe we should open a minor ticket to move this over to keyword only arguments for both.
| @@ -220,6 +236,7 @@ def accept(*args, **kwargs): | |||
|
|
|||
| defines_strategy = base_defines_strategy(False) | |||
| defines_strategy_with_reusable_values = base_defines_strategy(True) | |||
| defines_strategy_without_laziness = base_defines_strategy(False, try_non_lazy=True) | |||
There was a problem hiding this comment.
Also no need to do this in this PR but I kinda feel like we should just inline all of these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2507. This is kinda fiddly, but not as bad as I expected... all we really lose is the "repr preserves sequence type" thing and there's no good way to do that without storing a shallow copy of whatever we're sampling just for the repr.