Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tabs opening - generator #154

Closed
Mattdevinit opened this issue Oct 1, 2014 · 3 comments
Closed

Multiple tabs opening - generator #154

Mattdevinit opened this issue Oct 1, 2014 · 3 comments

Comments

@Mattdevinit
Copy link
Contributor

Seems to be opening 2 identical tabs, when clicking through on a generated number?

(also, not related, but I often find when you've chosen a country from the front page of d-portal, and then go back, you have to hit back twice)

@notshi
Copy link
Collaborator

notshi commented Oct 1, 2014

Thanks, Matt. It's one of the things to fix.

This was mostly due to allowing 2 ways of opening a link via the table:

  1. Allow clicking of the entire column anywhere uses javascript which will not allow a user to have access to right-click mouse options, eg. if the users wants to open the link in a different tab or window.
  2. Allow it as a traditional link that allows you the above option, browser friendly in terms of accessibility, ie. some users use tab to get to links.

@notshi notshi added the bug label Dec 18, 2014
@Mattdevinit Mattdevinit added this to the March 2015 milestone Feb 3, 2015
@Mattdevinit Mattdevinit modified the milestones: April 2015, March 2015 Mar 27, 2015
@Mattdevinit Mattdevinit modified the milestones: July 2015, April 2015 Jun 24, 2015
@Mattdevinit Mattdevinit modified the milestones: September 2015, July 2015 Sep 10, 2015
@notshi notshi closed this as completed Sep 25, 2015
@Mattdevinit
Copy link
Contributor Author

This one still happens for me, eg generating a table of content on the generator http://www.d-portal.org/ctrack.html?#view=generator page and then clicking on a cell within the generated table below, opens up 2 identical new tabs. Using Firefox v41.0

@notshi
Copy link
Collaborator

notshi commented Jan 28, 2016

Have updated a bunch of files and removed unnecessary hyperlinks - hopefully this is now fixed on Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants