Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve internal resources using FileResourceServer ensuring path is standardized. #1278

Merged
merged 2 commits into from
May 23, 2018

Conversation

kilnerm
Copy link
Contributor

@kilnerm kilnerm commented May 23, 2018

Revert changes to serve internal resources using static file server.
Ensure serving path are standardized.
Add further tests to check serving boundaries.

@kilnerm kilnerm self-assigned this May 23, 2018
@kilnerm kilnerm requested a review from ianpartridge May 23, 2018 06:59
@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #1278 into master will increase coverage by 0.82%.
The diff coverage is 83.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1278      +/-   ##
==========================================
+ Coverage   88.14%   88.97%   +0.82%     
==========================================
  Files          38       39       +1     
  Lines        2404     2412       +8     
==========================================
+ Hits         2119     2146      +27     
+ Misses        285      266      -19
Flag Coverage Δ
#Kitura 88.97% <83.96%> (+0.82%) ⬆️
Impacted Files Coverage Δ
...ces/Kitura/staticFileServer/StaticFileServer.swift 94.73% <100%> (+9.55%) ⬆️
Sources/Kitura/staticFileServer/FileServer.swift 91.25% <77.77%> (+8.07%) ⬆️
Sources/Kitura/Router.swift 83.87% <82.35%> (+0.27%) ⬆️
Sources/Kitura/FileResourceServer.swift 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91f7fb0...f3d0008. Read the comment docs.

@ianpartridge ianpartridge merged commit d663295 into master May 23, 2018
@ianpartridge ianpartridge deleted the issue.843-kitura-master branch May 23, 2018 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants