Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect index in LFR #83

Closed
louisabraham opened this issue May 9, 2019 · 3 comments
Closed

Incorrect index in LFR #83

louisabraham opened this issue May 9, 2019 · 3 comments

Comments

@louisabraham
Copy link

I'm pretty sure it should be

dists = np.zeros((N, k))

as dists matches the distance between each data sample and prototype.

https://github.com/IBM/AIF360/blob/master/aif360/algorithms/preprocessing/lfr_helpers/helpers.py#L10-L17

@pronics2004
Copy link
Contributor

That sound right and thanks for pointing this out.

The final results should not be affected as M_nk loops over k.

@louisabraham
Copy link
Author

Yes, as long as k < P (else you have a bound error).

@pronics2004
Copy link
Contributor

Yes, you are right. Thanks. Should be fixed in PR #84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants