Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javadoc and convenience methods for Base64Binary #1186

Closed
lmsurpre opened this issue Jun 2, 2020 · 0 comments
Closed

Add javadoc and convenience methods for Base64Binary #1186

lmsurpre opened this issue Jun 2, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Jun 2, 2020

Is your feature request related to a problem? Please describe.
I was trying to use Base64Binary.Builder and noticed that the Builder.value(String) method doesn't have javadoc.

Describe the solution you'd like
We need to add that so that we know whether to pass a string that has already been base64-encoded or if it will automatically base64-encoded string that was passed.

Also, I'd like there to be a Base64Binary.of(byte[]) method

@prb112 prb112 added the enhancement New feature or request label Feb 1, 2021
prb112 added a commit that referenced this issue Mar 26, 2021
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 self-assigned this Mar 26, 2021
@prb112 prb112 added this to the Sprint 2021-04 milestone Mar 26, 2021
prb112 added a commit that referenced this issue Mar 26, 2021
Add javadoc and convenience methods for Base64Binary #1186
lmsurpre added a commit that referenced this issue Mar 31, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 31, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants