Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling for invalid profiles / extension definitions #1447

Closed
JohnTimm opened this issue Aug 25, 2020 · 1 comment
Closed

Improve error handling for invalid profiles / extension definitions #1447

JohnTimm opened this issue Aug 25, 2020 · 1 comment
Assignees
@JohnTimm
Labels
bug Something isn't working
Milestone
Sprint 17

Comments

@JohnTimm
Copy link
Collaborator

ProfileSupport.isApplicable throws a NullPointerException when the StructureDefinition.type element is null. We should protect against this scenario and also log a warning that will be useful in debugging.
@JohnTimm JohnTimm added this to the Sprint 16 milestone Aug 25, 2020
@JohnTimm JohnTimm self-assigned this Aug 25, 2020
@JohnTimm
Copy link
Collaborator Author

After further investigation, this can also happen when there is a problem loading the resource through RegistryResourceUtil.loadResource.

@lmsurpre lmsurpre modified the milestones: Sprint 16, Sprint 17 Aug 25, 2020
@lmsurpre lmsurpre added the bug Something isn't working label Aug 25, 2020
JohnTimm added a commit that referenced this issue Aug 28, 2020
@JohnTimm
Issue #1447 - added null checking to ProfileSupport.isApplicable
82ab92e 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Aug 28, 2020
@JohnTimm
Issue #1447 - added null checking to ProfileSupport.isApplicable (#1455)
0d20e9e 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@prb112 prb112 closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnTimm JohnTimm

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 17
Development

No branches or pull requests
3 participants
@prb112 @lmsurpre @JohnTimm