Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameter in add_any_resources stored proc and delete unused SetTenantDAO #1566

Closed
prb112 opened this issue Oct 7, 2020 · 1 comment
Closed

Remove unused parameter in add_any_resources stored proc and delete unused SetTenantDAO #1566

prb112 opened this issue Oct 7, 2020 · 1 comment
Assignees
@prb112
Labels
bug Something isn't working
Milestone
Sprint 19

Comments

@prb112
Copy link
Contributor

prb112 commented Oct 7, 2020

Describe the bug

  1. p_source_key in add_any_resources.sql is unused (corresponding call needs update)
  2. com.ibm.fhir.persistence.jdbc.dao.impl.SetTenantDAO is unused

Additional context
n/a
@prb112 prb112 added the bug Something isn't working label Oct 7, 2020
@prb112 prb112 self-assigned this Oct 7, 2020
@prb112 prb112 added this to the Sprint 19 milestone Oct 7, 2020
prb112 added a commit that referenced this issue Oct 7, 2020
@prb112
Code Cleanup needed #1566
c39d40f 
- cleans up the unused p_source_key
- removes SetTenantDAO.java (unused)

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 linked a pull request Oct 7, 2020 that will close this issue
Code Cleanup needed #1566 #1567
Closed
prb112 added a commit that referenced this issue Oct 7, 2020
@prb112
Code Cleanup needed #1566
cb6e500 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
Copy link
Contributor Author

prb112 commented Nov 2, 2020

PR waiting review

@prb112 prb112 closed this as completed Nov 3, 2020
@lmsurpre lmsurpre changed the title Code Cleanup needed Remove unused parameter in add_any_resources stored proc and delete unused SetTenantDAO Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 19
Development

Successfully merging a pull request may close this issue.

Code Cleanup needed #1566 LinuxForHealth/FHIR
1 participant
@prb112