Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate representaton of what was searched for in the search output link URL #1670

Closed
d0roppe opened this issue Nov 4, 2020 · 3 comments
Assignees
Labels
bug Something isn't working search

Comments

@d0roppe
Copy link
Collaborator

d0roppe commented Nov 4, 2020

Is your feature request related to a problem? Please describe.
When you issue a search to FHIR, it outputs a link url that has what it searched on. Like adding the _count if one was not issued, or adding the _page=1. but it also fills in information like expanding out the time if you searched on a date. but that time is not really what was searched on.

Describe the solution you'd like
Would like the link url to accuratly show what was searched on especially for date/time
like a search on _lastUpdated=2020-04 is represented in the output link url as _lastUpdated=2020-04-01T00:00:00Z but that is not what the search was.

Describe alternatives you've considered

Acceptance Criteria

Additional context

@kmbarton423
Copy link
Contributor

either of the following is acceptable:

  • self url in response matches the partial datetime passed in the request
  • specify the range actually used

@kmbarton423 kmbarton423 added the bug Something isn't working label Nov 9, 2020
@lmsurpre lmsurpre added this to the Sprint 2021-1 milestone Dec 8, 2020
@tbieste tbieste self-assigned this Jan 27, 2021
tbieste added a commit that referenced this issue Jan 28, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Jan 28, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Jan 28, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@tbieste
Copy link
Contributor

tbieste commented Jan 28, 2021

Dates in the link urls (self, prev, next) will match the partial dates passed in the request. This will allow paging to work properly.

tbieste added a commit that referenced this issue Jan 29, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@d0roppe
Copy link
Collaborator Author

d0roppe commented Feb 3, 2021

verified with multiple date searches.

@d0roppe d0roppe closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working search
Projects
None yet
Development

No branches or pull requests

4 participants