-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support _sort with _include and _revinclude #1915
Comments
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Issue #1915 - Support _sort with _include and _revinclude
I verified this via the following queries in our connectathon environment:
|
Is your feature request related to a problem? Please describe.
In SearchUtil.java we have the following code snippet:
I think we made that simplifying assumption when this was first implemented; we weren't sure what the proper behavior would be (should the sort apply to the include resources or just the match resources?).
Now I'm pretty confident that it should only apply to the match resources and I think we should be able to support these parameters when used in combination.
Describe the solution you'd like
Apply the _sort to the search so that we get the first
_count
target resources that match the query. Then add in the include/revinclude resources for this page of results.Describe alternatives you've considered
Continue to disable the use of these parameters together.
Additional context
The text was updated successfully, but these errors were encountered: