-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The default fhir-server-config file-based bulk storageProvider should point to an existing directory #2086
Comments
Paul recommended that we include an extra level to make it easier to do mounts properly. |
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Issue #2086 - Change default bulkdata directory
I built the latest docker image and then ran it with a command like this:
I loaded a single patient and then invoked export. To my delight, it "just works" with the default config now. The exported file was available within the container under /output/bulkdata. Next I added an additional volume mount as follows:
I repeated the export and now the export was under my host's /tmp/bulkdata directory. Awesome. |
Is your feature request related to a problem? Please describe.
Our default config has
"fileBase": "/fhir-server/output"
. However, this location doesn't exist by default and so, to make it functional, a user must either:A. change this default setting in fhir-server-config.json; or
B. create this absolute directory for the output
I believe that this was done so that our config would work in our CI across both windows and linux.
Describe the solution you'd like
Our docker container already has a symlink from
/output
to/opt/ol/wlp/usr/servers/fhir-server
(with the proper user permissions I think), so maybe we can just create a directory namebulkdata
in that location and set the default to/output/bulkdata
?Describe alternatives you've considered
Document steps for having a volume mount at the existing default directory instead:
/fhir-server/output
Acceptance Criteria
1.
GIVEN [a precondition]
AND [another precondition]
WHEN [test step]
AND [test step]
THEN [verification step]
AND [verification step]
Additional context
Add the target directory to our docker image
The text was updated successfully, but these errors were encountered: