-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Squelch opd-0 warnings during startup #2241
Milestone
Comments
lmsurpre
added a commit
that referenced
this issue
Apr 13, 2021
With this pull request, the spec-defined OperationDefinitions are now pulled from the registry instead of having them copied to each individual module. Additionally, because so many of these spec-defined OperationDefinitions violate opd-0 (`name.matches('[A-Z]([A-Za-z0-9_]){0,254}')`), I toned down the logging so that only validation errors are logged by default (and not validation warnings). Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 13, 2021
With this pull request, the spec-defined OperationDefinitions are now pulled from the registry instead of having them copied to each individual module. Additionally, because so many of these spec-defined OperationDefinitions violate opd-0 (`name.matches('[A-Z]([A-Za-z0-9_]){0,254}')`), I toned down the logging so that only validation errors are logged by default (and not validation warnings). Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Apr 13, 2021
With this pull request, the spec-defined OperationDefinitions are now pulled from the registry instead of having them copied to each individual module. Additionally, because so many of these spec-defined OperationDefinitions violate opd-0 (`name.matches('[A-Z]([A-Za-z0-9_]){0,254}')`), I toned down the logging so that only validation errors are logged by default (and not validation warnings). Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Confirmed - does not show on info, it does show with fine in the trace.log
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Our startup log is getting cleaner and cleaner, but there's still a number of info messages that include the word "warning" on each start.
I believe they comes from validating OperationDefinition resources during initialization (or something like that) and it should be possible to get these cleaned up.
Describe the solution you'd like
Either
A. add a name to the artifacts that are missing one, so that we don't have this issue any more; or
B. turn these log messages into trace messages instead
Describe alternatives you've considered
Acceptance Criteria
1.
WHEN you start the server with the default config
THEN there are no log messages about
invariant:warning:opd-0
Additional context
The issue may be rooted in published spec artifacts. If so, we'll need to make a decision about whether to patch the spec artifacts or not.
The text was updated successfully, but these errors were encountered: