Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for generating constraints from slices with the "profile" discriminator type #2290

Closed
JohnTimm opened this issue Apr 26, 2021 · 3 comments
Closed

Add support for generating constraints from slices with the "profile" discriminator type #2290

JohnTimm opened this issue Apr 26, 2021 · 3 comments
Assignees
@JohnTimm
Labels
bug Something isn't working P2 Priority 2 - Should Have profiling showcase Used to Identify End-of-Sprint Demos
Milestone
Sprint 2021-06

Comments

@JohnTimm
Copy link
Collaborator

We currently don't support the "profile" discriminator type when generating constraints from slices and therefore we end up with FHIRPath constraints that are syntactically valid but lead to an IllegalArgumentException. For example:

contained.exists() implies (contained.exists() and contained.conformsTo('http://hl7.org/fhir/us/spl/StructureDefinition/USAgentAffiliation'))

The constraint is syntactically correct but the conformsTo function will generate an IllegalArgumentException because it checks isResource and isElement which both check isSingleton.
@JohnTimm JohnTimm added the bug Something isn't working label Apr 26, 2021
@JohnTimm JohnTimm self-assigned this Apr 26, 2021
@lmsurpre lmsurpre added this to the Sprint 2021-06 milestone Apr 27, 2021
@lmsurpre
Copy link
Member

See #2288 for the IG that causes this issue

@lmsurpre lmsurpre added the P2 Priority 2 - Should Have label Apr 27, 2021
JohnTimm added a commit that referenced this issue Apr 29, 2021
@JohnTimm
Issue #2290 - pom.xml updates
8318881 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 29, 2021
@JohnTimm
Issue #2290 - prepare ConstraintGenerator fine grained unit testing
d60cbd2 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 29, 2021
@JohnTimm
Issue #2290 - prepare ConstraintGenerator for A/B comparison testing
fbdeeb4 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 29, 2021
@JohnTimm
Issue #2290 - updates to ProfileSupport and ResolveFunction
8de2873 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 29, 2021
@JohnTimm
Issue #2290 - avoid redundant constraint definitions
1225171 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 29, 2021
@JohnTimm
Issue #2290 - update copyright year
a22d7d0 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 6, 2021
@JohnTimm
Issue #2290 - updates
8c0047e 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 7, 2021
@JohnTimm
Issue #2290 - conformsTo optimization
dfa966f 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 7, 2021
@JohnTimm
Issue #2290 - changed SearchParamType.ValueSet -> SearchParamType.Value
bd777dc 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 7, 2021
@JohnTimm
Issue #2290 - updated ConstraintGenerator trace logging
3102719 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 7, 2021
@JohnTimm
Issue #2290 - update copyright header
83cc4dc 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 7, 2021
@JohnTimm
Issue #2290 - minor tweaks to ProfileSupport
4ae4f21 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm mentioned this issue May 7, 2021
Merged
JohnTimm added a commit that referenced this issue May 7, 2021
@JohnTimm
Issue #2290 - fix whitespace in test-device.json
19726f2 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
prb112 added a commit that referenced this issue May 7, 2021
@prb112
Merge pull request #2288 from IBM/feat-fhir-ig-spl
b563f6d 
Issue #2290: Update constraint generator and introduce fhir-ig-spl module
@prb112
Copy link
Contributor

prb112 commented May 7, 2021

Moved to QA

@prb112
Copy link
Contributor

prb112 commented May 11, 2021

Reviewed and discussed with John - closing the issue.

@prb112 prb112 closed this as completed May 11, 2021
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - pom.xml updates
c70be43 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - prepare ConstraintGenerator fine grained unit testing
676195d 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - prepare ConstraintGenerator for A/B comparison testing
21665b0 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - updates to ProfileSupport and ResolveFunction
4f4c08a 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - avoid redundant constraint definitions
ff90a36 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - update copyright year
9af2193 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - updates
3392a45 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - conformsTo optimization
ae521c3 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - changed SearchParamType.ValueSet -> SearchParamType.Value
ee8c616 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - updated ConstraintGenerator trace logging
856cb2c 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - update copyright header
e63ec07 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - minor tweaks to ProfileSupport
f834e75 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
michaelwschroeder pushed a commit that referenced this issue May 11, 2021
@JohnTimm @michaelwschroeder
Issue #2290 - fix whitespace in test-device.json
0b3e4ee 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@lmsurpre lmsurpre added the showcase Used to Identify End-of-Sprint Demos label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnTimm JohnTimm

Labels
bug Something isn't working P2 Priority 2 - Should Have profiling showcase Used to Identify End-of-Sprint Demos
Projects
None yet
Milestone
Sprint 2021-06
Development

No branches or pull requests
3 participants
@prb112 @lmsurpre @JohnTimm