Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanity URLs with AWS result in bucket NOT_FOUND on $import #2411

Closed
prb112 opened this issue May 21, 2021 · 2 comments
Closed

Vanity URLs with AWS result in bucket NOT_FOUND on $import #2411

prb112 opened this issue May 21, 2021 · 2 comments
Assignees
@prb112
Labels
bug Something isn't working bulk-data
Milestone
Sprint 2021-08

Comments

@prb112
Copy link
Contributor

prb112 commented May 21, 2021

Describe the bug
Vanity URLs with AWS result in bucket NOT_FOUND on $import

Environment
Which version of IBM FHIR Server? 4.8.1

To Reproduce
Steps to reproduce the behavior:

  1. On AWS, create a bucket such as my-bucket
  2. Configure bulkdata with a external and internal endpoint with the bucketized url https://my-bucket.s3.notmyhost.host.com
    Note: the api endpoint works fine.
  3. Execute an $import with a file that exist

Expected behavior
The File should be imported

Additional context
@d0roppe found this while testing.
@prb112 prb112 added bug Something isn't working bulk-data labels May 21, 2021
@prb112 prb112 added this to the Sprint 2021-07 milestone May 21, 2021
@prb112 prb112 self-assigned this May 21, 2021
prb112 added a commit that referenced this issue May 21, 2021
@prb112
Vanity URLs with AWS result in bucket NOT_FOUND on #2411
bba7226 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue May 27, 2021
@prb112
Merge pull request #2412 from IBM/issue-2411
95123b0 
Vanity URLs with AWS result in bucket NOT_FOUND on  #2411
prb112 added a commit that referenced this issue Jun 3, 2021
@prb112
Vanity URLs with AWS result in bucket NOT_FOUND on $import #2411
fe1eebb 
- Update the Host support for Path/VirtualHost
- Update the DownloadUrl to support Urls/Presigned Urls with
VirtualHosts
- Update settings to support accessType - path, host
- Refactor BulkDataClient to log out using llambdas


Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
Copy link
Contributor Author

prb112 commented Jun 3, 2021

PR https://github.com/IBM/FHIR/pull/2465/files

tbieste pushed a commit that referenced this issue Jun 9, 2021
@prb112 @tbieste
Merge pull request #2412 from IBM/issue-2411
6567376 
Vanity URLs with AWS result in bucket NOT_FOUND on  #2411
@d0roppe
Copy link
Collaborator

d0roppe commented Jun 21, 2021

with the documented change of only allowing the vanity URL on the endpointExternal URL it is working
"endpointInternal": "https://s3.region.host-name.com",
"endpointExternal": "https://bucket-name.s3.region.host-name.com",

@d0roppe d0roppe closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

Labels
bug Something isn't working bulk-data
Projects
None yet
Milestone
Sprint 2021-08
Development

No branches or pull requests
3 participants
@prb112 @lmsurpre @d0roppe