Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure headers in RemoteTermServiceProvider configuration #2431

Closed
csandersdev opened this issue May 26, 2021 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@csandersdev
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I want to be able to target a specific tenant on an IBM FHIR instance as the terminology provider for a multi-tenant system. My idea is to use the remoteTermServiceProvider to achieve that, but it is not possible right now to pass headers and thus target a specific tenant.

Describe the solution you'd like
I would like the ability to configure header information in the remoteTermServiceProvider configuration which will be passed to the FHIRClient during execution time.

Describe alternatives you've considered
We could set it up so that there is a separate FHIR server cluster that serves terminology from the default tenant instead of using a tenant within our patient data server cluster and that would avoid the need to pass the tenant ID header.

Acceptance Criteria

  1. GIVEN a multi-tenant fhir server installation
    AND separate data and terminology tenants exist
    AND configuration properties exist for configuring headers in the remoteTermServerProvider configuration exist
    WHEN the user configures the remoteTermServiceProvider to point to the localhost with a specific tenant-id header
    THEN terminology data is leveraged from the separate tenant.

Additional context
Add any other context or screenshots about the feature request here.

JohnTimm added a commit that referenced this issue May 26, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@prb112 prb112 added the enhancement New feature or request label May 26, 2021
JohnTimm added a commit that referenced this issue May 26, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 26, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 26, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 26, 2021
…2435)

* Issue #2431 - add support for headers in RemoteTermServiceProvider

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2431 - update docs

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2432 - add dependsOnMethods to annotation

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2431 - minor tweak

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2431 - fix integration test

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 27, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 27, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@prb112 prb112 added this to the Sprint 2021-07 milestone May 27, 2021
@lmsurpre
Copy link
Member

lmsurpre commented Jun 3, 2021

@CoreySandersOH this is merged into main and set to go out with the 4.8.3 release. Do you mind having a quick look and confirming it addresses your request?

@csandersdev
Copy link
Contributor Author

LGTM

@lmsurpre lmsurpre closed this as completed Jun 3, 2021
tbieste pushed a commit that referenced this issue Jun 9, 2021
…2435)

* Issue #2431 - add support for headers in RemoteTermServiceProvider

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2431 - update docs

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2432 - add dependsOnMethods to annotation

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2431 - minor tweak

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2431 - fix integration test

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
tbieste pushed a commit that referenced this issue Jun 9, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants