Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to fhir-persistence-schema about the plan to remove the Resource and DomainResource table groups #2445

Closed
lmsurpre opened this issue Jun 1, 2021 · 3 comments

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Jun 1, 2021

Is your feature request related to a problem? Please describe.
We plan to remove these tables under #713 but we don't want to break anyone that might be using these tables for something (though our schema does not).

Therefore lets do just a warning in 4.9 and save the actual removal for a future release.

Describe the solution you'd like
In 4.9.0 release notes, add a note under the "deprecated" section that we plan to remove the Resource and DomainResource tables in the next minor release (e.g. 4.10).

Add warning in fhir-persistence-schema output stating that we plan to delete data in the next release.

Describe alternatives you've considered
Just don't do it

Acceptance Criteria

  1. GIVEN [a precondition]
    AND [another precondition]
    WHEN [test step]
    AND [test step]
    THEN [verification step]
    AND [verification step]

Additional context

@lmsurpre lmsurpre added the schema label Jun 1, 2021
@lmsurpre lmsurpre added this to the Sprint 2021-08 milestone Jun 1, 2021
@lmsurpre lmsurpre changed the title Avoid creating unnecessary tables for Resource and DomainResource resource types Add warning to fhir-persistence-schema about the plan to remove the Resource and DomainResource table groups Jun 1, 2021
@tbieste
Copy link
Contributor

tbieste commented Jun 1, 2021

Confirming the full list of tables to be "deprecated":

DOMAINRESOURCE_DATE_VALUES
DOMAINRESOURCE_LATLNG_VALUES
DOMAINRESOURCE_LOGICAL_RESOURCES
DOMAINRESOURCE_NUMBER_VALUES
DOMAINRESOURCE_QUANTITY_VALUES
DOMAINRESOURCE_RESOURCE_TOKEN_REFS
DOMAINRESOURCE_RESOURCES
DOMAINRESOURCE_STR_VALUES
RESOURCE_DATE_VALUES
RESOURCE_LATLNG_VALUES
RESOURCE_LOGICAL_RESOURCES
RESOURCE_NUMBER_VALUES
RESOURCE_QUANTITY_VALUES
RESOURCE_RESOURCE_TOKEN_REFS
RESOURCE_RESOURCES
RESOURCE_STR_VALUES

There's a few other tables that start with RESOURCE_xxxx, but those should remain.

@tbieste tbieste self-assigned this Jun 1, 2021
tbieste added a commit that referenced this issue Jun 1, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@lmsurpre
Copy link
Member Author

lmsurpre commented Jun 2, 2021

Yes, that looks right to me.

tbieste added a commit that referenced this issue Jun 3, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@tbieste tbieste modified the milestones: Sprint 2021-08, Sprint 2021-07 Jun 3, 2021
tbieste added a commit that referenced this issue Jun 3, 2021
Issue #2445 - Log warning messages about deprecated tables
@prb112
Copy link
Contributor

prb112 commented Jun 3, 2021

QA results for Postgres.
It looks good.

2021-06-03 12:22:22.798 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'DOMAINRESOURCE_DATE_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'DOMAINRESOURCE_LATLNG_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'DOMAINRESOURCE_LOGICAL_RESOURCES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'DOMAINRESOURCE_NUMBER_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'DOMAINRESOURCE_QUANTITY_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'DOMAINRESOURCE_RESOURCE_TOKEN_REFS' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'DOMAINRESOURCE_RESOURCES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'DOMAINRESOURCE_STR_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'RESOURCE_DATE_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'RESOURCE_LATLNG_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'RESOURCE_LOGICAL_RESOURCES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'RESOURCE_NUMBER_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'RESOURCE_QUANTITY_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'RESOURCE_RESOURCE_TOKEN_REFS' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'RESOURCE_RESOURCES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001 WARNING   com.ibm.fhir.schema.app.Main Table 'RESOURCE_STR_VALUES' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.
2021-06-03 12:22:22.799 00000001    INFO   com.ibm.fhir.schema.app.Main Processing took:  80.604 s
2021-06-03 12:22:22.800 00000001    INFO   com.ibm.fhir.schema.app.Main SCHEMA CHANGE: OK

@prb112 prb112 closed this as completed Jun 3, 2021
tbieste added a commit that referenced this issue Jun 9, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Jun 9, 2021
Issue #2445 - Log warning messages about deprecated tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants