Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discriminator incorrectly generated for profile constraints #2541

Closed
JohnTimm opened this issue Jun 22, 2021 · 1 comment
Closed

Discriminator incorrectly generated for profile constraints #2541

JohnTimm opened this issue Jun 22, 2021 · 1 comment
Assignees
@JohnTimm
Labels
bug Something isn't working P1 Priority 1 - Must Have
Milestone
Sprint 2021-10

Comments

@JohnTimm
Copy link
Collaborator

A recent change has introduced a bug that incorrectly generates the discriminator when the element definition has a profile constraint:

contained.where(conformsTo('http://hl7.org/fhir/us/spl/StructureDefinition/USAgentAffiliation')) and contained.count() = 1.exists()

the and contained.count() = 1 was recently added to address another issue but when generating the discriminator this clause causes issues
@JohnTimm JohnTimm added bug Something isn't working P1 Priority 1 - Must Have labels Jun 22, 2021
@JohnTimm JohnTimm self-assigned this Jun 22, 2021
JohnTimm added a commit that referenced this issue Jun 22, 2021
@JohnTimm
Issue #2541 - update generateProfileConstraint
6599a48 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jun 22, 2021
@JohnTimm
Issue #2541 - update generateProfileConstraint (#2542)
e352112 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@lmsurpre lmsurpre added this to the Sprint 2021-08 milestone Jun 22, 2021
JohnTimm added a commit that referenced this issue Jun 30, 2021
@JohnTimm
Issue #2541 - ConstraintGenerator updates
289489c 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jun 30, 2021
@JohnTimm
Issue #2541 - updates per PR comments
80697ab 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@d0roppe d0roppe modified the milestones: Sprint 2021-08, Sprint 2021-09 Jul 1, 2021
JohnTimm added a commit that referenced this issue Jul 7, 2021
@JohnTimm
Issue #2541 - updates
2edb718 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jul 7, 2021
@JohnTimm
Issue #2541 - updates per PR comments
8174655 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jul 7, 2021
@JohnTimm
Issue #2541 - ConstraintGenerator updates (#2566)
1a2b5fd 
* Issue #2541 - ConstraintGenerator updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2541 - updates per PR comments

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2541 - updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2541 - updates per PR comments

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@prb112 prb112 modified the milestones: Sprint 2021-09, Sprint 2021-10 Jul 16, 2021
@prb112
Copy link
Contributor

prb112 commented Jul 28, 2021

QA and review completed with the spl ig.

@prb112 prb112 closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnTimm JohnTimm

Labels
bug Something isn't working P1 Priority 1 - Must Have
Projects
None yet
Milestone
Sprint 2021-10
Development

No branches or pull requests
4 participants
@prb112 @lmsurpre @JohnTimm @d0roppe