Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for searching references by identifier #773

Closed
lmsurpre opened this issue Mar 11, 2020 · 3 comments
Closed

Support for searching references by identifier #773

lmsurpre opened this issue Mar 11, 2020 · 3 comments
Assignees
Labels
P2 Priority 2 - Should Have reference-search reindex Resolution of issue will require a $reindex during upgrade search

Comments

@lmsurpre
Copy link
Member

From https://www.hl7.org/fhir/search.html#reference:

References are also allowed to have an identifier. The modifier :identifier allows for searching by the identifier rather than the literal reference:

GET [base]/Observation?subject:identifier=http://acme.org/fhir/identifier/mrn|123456
This is a search for all observations that reference a patient by a particular patient MRN. When the :identifier modifier is used, the search value works as a token search. The :identifier modifier is not supported on canonical elements since they do not have an identifier separate from the reference itself.

Chaining is not supported when using the :identifier modifier, nor are chaining, includes or reverse includes supported for reference elements that do not have a reference element.

@lmsurpre
Copy link
Member Author

We think we're already handling the extraction side of this one, so it should be just a matter of updating our query generator to look in the TOKEN_VALUES_V view with the identifier system+value instead of the reference value.

@lmsurpre
Copy link
Member Author

Currently, we don't even extract the identifier field of reference elements, so that would be step 1.

@lmsurpre lmsurpre added reindex Resolution of issue will require a $reindex during upgrade P2 Priority 2 - Should Have labels Mar 15, 2021
@tbieste tbieste self-assigned this Mar 17, 2021
@tbieste tbieste added this to the Sprint 2021-04 milestone Mar 17, 2021
tbieste added a commit that referenced this issue Mar 17, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 17, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 17, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 17, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 17, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 18, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 18, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 18, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 18, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 19, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 19, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 19, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste added a commit that referenced this issue Mar 19, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 22, 2021
Issue #773 - Add support for ':identifier' modifier
@prb112
Copy link
Contributor

prb112 commented Mar 23, 2021

Completed QA. Looks good and behaved as expected.

@prb112 prb112 closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority 2 - Should Have reference-search reindex Resolution of issue will require a $reindex during upgrade search
Projects
None yet
Development

No branches or pull requests

3 participants