Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #1508 - Initial delivery of fhir-meter project #1573

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Conversation

d0roppe
Copy link
Collaborator

@d0roppe d0roppe commented Oct 9, 2020

Detail: This is the initial delivery of the fhir-meter project
containing a readme and a JMeter test plan. The test plan is for
searching a FHIR server with preloaded resources where you can get a
list of resource ID's into a CSV file before you run the test. This is
meant to add load to the server through JMeter load testing.

Signed-off-by: Dag O. Roppe roppe@us.ibm.com

Detail: This is the initial delivery of the fhir-meter project
containing a readme and a JMeter test plan.  The test plan is for
searching a FHIR server with preloaded resources where you can get a
list of resource ID's into a CSV file before you run the test.  This is
meant to add load to the server through JMeter load testing.


Signed-off-by: Dag O. Roppe <roppe@us.ibm.com>
@d0roppe d0roppe requested a review from lmsurpre October 9, 2020 01:56
@lmsurpre lmsurpre added the new-module Flag for identifying PRs that introduce a new module (and therefor require manual work for release) label Oct 9, 2020
@lmsurpre
Copy link
Member

lmsurpre commented Oct 9, 2020

@prb112 do you think we need a copyright + license notice at the top of the jmx file?

@prb112
Copy link
Contributor

prb112 commented Oct 9, 2020

@prb112 do you think we need a copyright + license notice at the top of the jmx file?

I think we should. It should be best practice.

@prb112
Copy link
Contributor

prb112 commented Oct 9, 2020

@lmsurpre @d0roppe
As this is not packaged into a maven project, I don't think it falls under the new-module. I want to double check the tag.

Is this intended to be released to bintray or packaged for release?

Detail:  Review comment to add a copyright statement the test file.
This is the same file with the copyright added.

Signed-off-by: Dag O. Roppe <roppe@us.ibm.com>
@lmsurpre lmsurpre removed the new-module Flag for identifying PRs that introduce a new module (and therefor require manual work for release) label Oct 9, 2020
@lmsurpre
Copy link
Member

lmsurpre commented Oct 9, 2020

As this is not packaged into a maven project, I don't think it falls under the new-module. I want to double check the tag.
Is this intended to be released to bintray or packaged for release?

good call. i don't think it needs any packaging/deployment at this time and thus i have have removed the label.

Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d0roppe per the convo with paul, could you please add a copyright + license notice to the top of the jmx file?
probably via an xml comment like

<!-- 
(C) Copyright IBM Corp. 2020

SPDX-License-Identifier: Apache-2.0
-->

Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havn't run these myself, but I think it looks good to me.

@prb112 prb112 merged commit 4eb298a into master Oct 9, 2020
@prb112 prb112 deleted the issue-1508 branch October 9, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants