-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #1508 - Initial delivery of fhir-meter project #1573
Conversation
Detail: This is the initial delivery of the fhir-meter project containing a readme and a JMeter test plan. The test plan is for searching a FHIR server with preloaded resources where you can get a list of resource ID's into a CSV file before you run the test. This is meant to add load to the server through JMeter load testing. Signed-off-by: Dag O. Roppe <roppe@us.ibm.com>
@prb112 do you think we need a copyright + license notice at the top of the jmx file? |
I think we should. It should be best practice. |
Detail: Review comment to add a copyright statement the test file. This is the same file with the copyright added. Signed-off-by: Dag O. Roppe <roppe@us.ibm.com>
good call. i don't think it needs any packaging/deployment at this time and thus i have have removed the label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d0roppe per the convo with paul, could you please add a copyright + license notice to the top of the jmx file?
probably via an xml comment like
<!--
(C) Copyright IBM Corp. 2020
SPDX-License-Identifier: Apache-2.0
-->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I havn't run these myself, but I think it looks good to me.
Detail: This is the initial delivery of the fhir-meter project
containing a readme and a JMeter test plan. The test plan is for
searching a FHIR server with preloaded resources where you can get a
list of resource ID's into a CSV file before you run the test. This is
meant to add load to the server through JMeter load testing.
Signed-off-by: Dag O. Roppe roppe@us.ibm.com