Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 380 #551

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Issue 380 #551

merged 3 commits into from
Jan 6, 2020

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Dec 30, 2019 •
edited
Loading

Cleans up the feature gaps and test gaps in database tools

@prb112
Add dryrun functionality to the fhir-persistence-schema Main #380
ee1053d 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
WhereAdapter passes in the SELECT predict and not the parameter
5261a1d 
expression #274

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 added the bug Something isn't working label Dec 30, 2019
@prb112 prb112 self-assigned this Dec 30, 2019
@prb112 prb112 mentioned this pull request Dec 30, 2019
Closed
@prb112
Copy link
Contributor Author

prb112 commented Dec 30, 2019

Please merge other PRs first

[ERROR]   JDBCSearchDateTest>AbstractSearchDateTest.testSearchDate_dateTime_Day_noTZ:640->AbstractPLSearchTest.assertSearchReturnsSavedResource:115 Expected resource was not returned from the search

@lmsurpre lmsurpre self-requested a review January 6, 2020 21:39
lmsurpre
lmsurpre approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I flagged a few spots where the formatter inserted an akward line break. Otherwise LGTM.

@prb112
WhereAdapter passes in the SELECT predict and not the parameter #274
24c5add 
- fixes PR review stuff

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
Copy link
Contributor Author

prb112 commented Jan 6, 2020

I flagged a few spots where the formatter inserted an akward line break. Otherwise LGTM.

Got them... Main.java is significantly refactored since this change, so I'm opting to not change (reduce potential conflicts)

lmsurpre
lmsurpre approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prb112 prb112 merged commit 420dcb7 into master Jan 6, 2020
@prb112 prb112 deleted the issue-380 branch January 6, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmsurpre lmsurpre lmsurpre approved these changes

@JohnTimm JohnTimm JohnTimm approved these changes

Assignees

@prb112 prb112

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prb112 @lmsurpre @JohnTimm