You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In Travis-CI, we only build on the merge, not the PR.
script:
# Have audit-ci run audit-ci to audit itself :)
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then node lib/audit-ci.js -l --config ./audit-ci.json; fi
However, on CircleCI, we build on the PR:
# In your code, add this (after installing with `npm install --save-dev audit-ci`):# - run:# name: run-audit-ci# command: 'audit-ci --moderate'# Have audit-ci run audit-ci to audit itself :)
- run:
name: run-audit-cicommand: node lib/audit-ci.js -l --config ./audit-ci.json
This can result in the following scenario:
Push a new feature with PR, but master has new vulnerabilities, breaking the PR
Create a fix PR with the new advisories, merge PR into master
Re-run the feature workflow
Travis-CI will pass
CircleCI will fail
The expected behaviour (Travis-CI and CircleCI): pass.
The current behaviour: Travis-CI - pass, CircleCI - fail.
CircleCI should build on the merge rather than the PR.
This issue would be resolved by:
Updating the docs to suggest the new CircleCI workflow implementation
Implement the new CircleCI workflow
The text was updated successfully, but these errors were encountered:
In Travis-CI, we only build on the merge, not the PR.
However, on CircleCI, we build on the PR:
This can result in the following scenario:
feature
with PR, butmaster
has new vulnerabilities, breaking the PRfeature
workflowThe expected behaviour (Travis-CI and CircleCI):
pass
.The current behaviour: Travis-CI -
pass
, CircleCI -fail
.CircleCI should build on the merge rather than the PR.
This issue would be resolved by:
The text was updated successfully, but these errors were encountered: