Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use display: unset instead of display: block for dealing with the --0 utility selectors. #35

Open
TazmanianDI opened this issue Mar 19, 2018 · 2 comments

Comments

@TazmanianDI
Copy link
Member

There is a set of utility classnames that you can add to an element that just tells the element how many columns to span at a given breakpoint so you don't have to declare explicit grid positioning for the element (e.g. ibm-grid__col--lg--2).

This includes the ability to hide a column with --0 which uses display: block. To override this at higher breakpoints, the selectors use display: block but display: unset should achieve the same thing without offering an opinion about just which type of display the element should be add.

@seejamescode
Copy link
Contributor

seejamescode commented Mar 19, 2018

unset is not supported in IE and I don’t think it would have the affect you really want. How about modifier classes to tell the element which display property it is toggling between?

@seejamescode
Copy link
Contributor

After talking more with you on Slack, it seems like the --0 rules should be contained in media queries with max-width included. Can you take this on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants