63 set right temp #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Release
* Informative error messages in async generator and type change in GenAI exception (IBM#57) * update greedy examples removing incompatible params (IBM#59) * Fix/setup cfg (IBM#49) * fix: including README in pypi deployment * fix: adding build dependency and changing workflow to use it Signed-off-by: James Sutton <james.sutton@uk.ibm.com> Co-authored-by: Mírian Silva <mirianfrsilva@ibm.com> Co-authored-by: James Sutton <1068763+jpwsutton@users.noreply.github.com>
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
Pull Request Test Coverage Report for Build 5424041787
💛 - Coveralls |
Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
Signed-off-by: James Sutton <jsutton@li-dcf9314c-2cb7-11b2-a85c-ee3a6b9d026b.ibm.com> Signed-off-by: James Sutton <james.sutton@uk.ibm.com>
- Fixed spellings on examples - Added API_URL examples to README Contributes to: IBM#24 Signed-off-by: Ja Young Lee <younglee@ibm.com>
- fixed wrong link on the documentation Contributes to: IBM#24 Signed-off-by: Ja Young Lee <younglee@ibm.com>
- Fixed wrong links on documentations Contributes to: IBM#24 Signed-off-by: Ja Young Lee <younglee@ibm.com> Co-authored-by: Ja Young Lee <younglee@ibm.com>
* Informative error messages in async generator and type change in GenAI exception (IBM#57) * update greedy examples removing incompatible params (IBM#59) * Fix/setup cfg (IBM#49) * fix: including README in pypi deployment * fix: adding build dependency and changing workflow to use it Signed-off-by: James Sutton <james.sutton@uk.ibm.com> Co-authored-by: Mírian Silva <mirianfrsilva@ibm.com> Co-authored-by: James Sutton <1068763+jpwsutton@users.noreply.github.com>
onkarbhardwaj
approved these changes
Jun 30, 2023
vedem1192
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
When the decoding mode is set to sampling, it isn't compatible with temperature=0. Set the temperature to 0.05 instead so it is compatible while still close to 0. I checked all other examples to confirm this is only the case in these 2 files, and confirmed that the greedy method is not paired with the parameters of top_k , top_p , seed , and temperature. When temperature is not set for a sample method parameter, the default is 1.
Impacted Areas in Library
User examples
Which issue(s) does this pull-request fix?
Closes: #63
Any special notes for your reviewer?
Checklist