Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update AnimalApp to fix a bug with running in browser+proxy dev … #5804

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Sep 28, 2020

…mode

Fixes #5803

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #5804 into master will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5804      +/-   ##
==========================================
- Coverage   61.19%   60.62%   -0.57%     
==========================================
  Files          83       83              
  Lines        2649     2649              
  Branches      654      654              
==========================================
- Hits         1621     1606      -15     
- Misses        788      800      +12     
- Partials      240      243       +3     
Impacted Files Coverage Δ
packages/core/src/webapp/views/registrar/modes.ts 50.00% <0.00%> (-31.82%) ⬇️
packages/core/src/models/RadioTable.ts 42.10% <0.00%> (-5.27%) ⬇️
packages/core/src/repl/exec.ts 71.80% <0.00%> (-3.20%) ⬇️
packages/core/src/models/tab-state.ts 63.07% <0.00%> (-1.54%) ⬇️
packages/core/src/repl/tab-completion.ts 73.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec17e8...873fc4a. Read the comment docs.

@starpit starpit merged commit 4f1e8dd into kubernetes-sigs:master Sep 29, 2020
@starpit starpit deleted the fix-5803 branch September 29, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update AnimalApp to fix a bug with running in browser+proxy dev mode
1 participant