Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MLX UI Startup Failure on OpenShift #44

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

ckadner
Copy link

@ckadner ckadner commented Jun 23, 2022

Which issue is resolved by this Pull Request:

Resolves machine-learning-exchange/mlx#343

Description of your changes:

Add security context to mlx-ui:

      securityContext:
        # runAsUser: 0  # root, prior to https://github.com/machine-learning-exchange/mlx/pull/339
        runAsNonRoot: true
        runAsUser: 1000  # node
        fsGroup: 1000  # node

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

/cc @Tomcli @yhwang @jbusche

surajkota and others added 3 commits June 21, 2022 08:14
* Update kubeflow/pipelines manifests from 1.8.2

* update example, tests
Run mlx-ui as node user (1000)

Resolves machine-learning-exchange/mlx#343

Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner changed the title Fix mlx UI 243 startup failure Fix MLX UI Startup Failure on OpenShift Jun 23, 2022
@Tomcli
Copy link

Tomcli commented Jun 23, 2022

/lgtm

@Tomcli Tomcli merged commit fa79475 into IBM:master Jun 23, 2022
@ckadner
Copy link
Author

ckadner commented Jun 23, 2022

Thanks @Tomcli and @yhwang -- for the v1.5-branch should I create a separate PR or could you merge/cherry-pick directly?

@yhwang
Copy link
Member

yhwang commented Jun 23, 2022

it's a merge, looks like you have to create another PR against v1.5-branch. Thanks

@ckadner
Copy link
Author

ckadner commented Jun 24, 2022

it's a merge, looks like you have to create another PR against v1.5-branch

@yhwang @Tomcli -- I created the same PR for the v1.5-branch. Please merge when you get a chance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mlx-ui pod fails to start up on OpenShift
4 participants