Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "src_peers" and "dst_peers" dimensions comparisons #485

Closed
tanyaveksler opened this issue Apr 18, 2023 · 0 comments · Fixed by #509
Closed

Fix "src_peers" and "dst_peers" dimensions comparisons #485

tanyaveksler opened this issue Apr 18, 2023 · 0 comments · Fixed by #509
Assignees
Labels
bug Something isn't working

Comments

@tanyaveksler
Copy link
Member

The src_peers and dst_peers dimensions are special dimensions, they do not have constant domain. Their domain depends on the current set of peers in the system (as appears in BasePeerSet singleton). This set grows when adding more configurations. Thus, there is no unique 'all values' representation. In particular, those dimensions are never reduced to inactive.
This might be a problem in comparison and inclusion operators of ConnectivityProperties. The possible solution may be to keep 'reference full domain value' for these dimensions (as another member in the BasePeerSet), and to set it to relevant values per query, while making a special treatment of these dimensions in the above comparison and inclusion operators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant