Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validator): Spurious errors when using application/merge-patch+json media type #198

Merged
merged 4 commits into from
Sep 22, 2020

Conversation

meem
Copy link
Contributor

@meem meem commented Sep 22, 2020

Fixes #197.

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2020

CLA assistant check
All committers have signed the CLA.

@dpopp07 dpopp07 self-requested a review September 22, 2020 18:52
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me 👍 Do you mind adding a test to capture this behavior?

I also would like to hear what @mkistler thinks about the change

@meem
Copy link
Contributor Author

meem commented Sep 22, 2020

@dpopp07 Thanks for the review, and good call on adding a test case. I added a specific one for this scenario, though I think we may need a broader rework of operations.test.js to account for both application/json and +json throughout.

Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Thanks for the contribution @meem !

@dpopp07
Copy link
Member

dpopp07 commented Sep 22, 2020

@meem thanks for adding the test - I think this looks good for now. If you would like to add further tests, feel free to open a subsequent PR. Thanks!

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks for the PR!

@dpopp07 dpopp07 merged commit 958b6af into IBM:master Sep 22, 2020
dpopp07 pushed a commit that referenced this pull request Sep 22, 2020
## [0.29.4](v0.29.3...v0.29.4) (2020-09-22)

### Bug Fixes

* recognize `application/merge-patch+json` media type as JSON ([#198](#198)) ([958b6af](958b6af))
@dpopp07
Copy link
Member

dpopp07 commented Sep 22, 2020

🎉 This PR is included in version 0.29.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious errors when using application/merge-patch+json media type
4 participants