-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(validator): Spurious errors when using application/merge-patch+json
media type
#198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me 👍 Do you mind adding a test to capture this behavior?
I also would like to hear what @mkistler thinks about the change
@dpopp07 Thanks for the review, and good call on adding a test case. I added a specific one for this scenario, though I think we may need a broader rework of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Thanks for the contribution @meem !
@meem thanks for adding the test - I think this looks good for now. If you would like to add further tests, feel free to open a subsequent PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 Thanks for the PR!
## [0.29.4](v0.29.3...v0.29.4) (2020-09-22) ### Bug Fixes * recognize `application/merge-patch+json` media type as JSON ([#198](#198)) ([958b6af](958b6af))
🎉 This PR is included in version 0.29.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #197.