Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add final/destination URL field to LighthouseRun object #38

Open
ecumike opened this issue Nov 9, 2018 · 0 comments
Open

Add final/destination URL field to LighthouseRun object #38

ecumike opened this issue Nov 9, 2018 · 0 comments
Labels
data model Requires updates to data models

Comments

@ecumike
Copy link
Contributor

ecumike commented Nov 9, 2018

The scenario is that a URL might be submitted for tracking, but is actually not the final destination URL (AKA; it's a redirect).

Other case is that a page might get moved or sunset and redirected to a new URL.

Storing the "final" URL for each LighthouseRun allows the insights to see that if there was a drastic change in performance or URL audit metrics, it may be because a different page is actually being tested for that URL than previous runs.

This is minimal effort and is data already provided in Lighthouse report data.
Add a field to LighthouseRun obj.
In the method where we process posted LighthouseRawdata, like we do other bits, grab the URL from the data object and add it to the LHrun record.

A follow-on UI piece will be covered in a separate issue.

@ecumike ecumike added the data model Requires updates to data models label Nov 9, 2018
@ecumike ecumike changed the title Add final/destination URL field to each LighthouseRun object Add final/destination URL field to LighthouseRun object Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
data model Requires updates to data models
Projects
None yet
Development

No branches or pull requests

1 participant