-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARABIC LIGATURE ALLAH is not handled correctly. #407
Comments
@munzirtaha Thank you for making this issue. We will certainly look into this issue. |
I'm curious how this can be solved best. Currently the feature code for the
Would it be better to remove the
|
Thanks @BoldMonday. Let’s see what Wael and Khajag include as well. |
@munzirtaha The solution @BoldMonday mentioned above is a possible solution. Another solution also mentioned by Khajag Apelian is to “remove the vocalization whatsoever from the original “allah” ligature, allowing the user to add the marks as they please.” The current solution in Plex Arabic is the standard in most typefaces. This requires (not be too difficult) a “find/replace” within indesign (or other tools) to whichever form of Allah one needs. |
I am not sure I understood the second solution. However, the solution mentioned by @BoldMonday is definitely better than the current situation. The font should not Ignore my Marks. The user knows better which marks are best suited for his specific text.
We can improve on this by removing only. So, ALLAH ligature will be used when both marks are explicitly included in the input text and when Common or Discretionary Ligatures is chosen. Typefaces like Traditional Arabic, Calibri, Tahoma, Arabic Typesetting, Sakkal Majalla, and Lotus Linotype chose Common. Whereas, Nassim Arabic e.g. chose Discretionary.
As you know, the typefaces I mentioned are the most widely used typefaces in the Arabic world even by the publishing industry. If their implementation is not the standard, I don't know how standard is measured. I haven't intentionally mentioned the Amiri typeface which contains many hacks and checks for surrounding letters and vowel marks to cover corner cases. It's enough to be correct and non-intrusive, no need for any AI for Plex. Most importantly, really thanks for your care. |
My solution to this is to have two versions of the ligature, one with the shadda and small alef and in a lookup without IgnoreMarks flag, and another version without the shadda and small alef in a lookup with IgnoreMarks flag. This way if any mark is present, the shadda and small alef are not automatically added (this does not handle the case of mark on the last letter, but I think it is a good compromise). The ligature should also have proper mark to ligature anchors. |
For a design like IBM Plex, I’d do away with the ligature altogether. The difference between the ligated and unligated glyphs is rather subtle (the added marks aside) and the ligature is needed in more classical designs where the difference is more pronounced. |
Thank you @khaledhosny. Your suggestion is well received by the team. We’ll plan for an update. |
We decided to implement the suggestion by @khaledhosny to have two versions of the ligature: one ligature with shadda and small alef included, and one ligature without those marks. The first ligature is triggered when no marks are in the input text. From right to left:
We'll implement this solutions across all styles and submit an update soon. |
Great! Thanks all. |
@BoldMonday Can I close this issue. Seems to be resolved. |
@mjabbink The issue has been resolved indeed. But it appears that this repository does not contain the updated files yet. |
@vpicone Can you let me know the status of the latest updates. |
Hi, I have large amounts of text that contains the Arabic ligature ALLAH, written as:
اللّه
which are five characters in Unicode
<U+0627|U+0644|U+0644|U+0651|U+0647>
This is expected to display the five characters written as they are, as shown by Noto Naskh Arabic font e.g
IBM plex Arabic is trying to be smart and add another
<U+0651>
which is simply wrong, beside adding aSUPERSCRIPT ALEF
which I don't want but might be acceptable depending on whom you ask, as shows inIt's not reasonable, I go and edit all my text by removing MY
<U+0651>
so Plex can add HIS<U+0651>
. I should also have the freedom not to have theSUPERSCRIPT ALEF
without editing the text. If the font still wants to be smart and guess in behalf of the user, at least doing it as in Amiri font could be acceptable. Amiri would try to guess the diacritics unless you typed your own, then it will leave you alone.The text was updated successfully, but these errors were encountered: