Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of support for int64 and uint64 from a protobug perspective #16

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

viveknshah
Copy link
Contributor

Fixes #11

Due to signed commit issues in #12 , redid from scratch to clean it up.

@viveknshah
Copy link
Contributor Author

@gabe-l-hart created a fresh PR with the signed-off-by message in the commit based on the DCO ask.

…@yahoo.com>

Signed-off-by: viveknshah <vivek_n_shah@yahoo.com>
Copy link
Collaborator

@gabe-l-hart gabe-l-hart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the updates!

@gabe-l-hart gabe-l-hart merged commit 6a86efc into IBM:main Nov 1, 2022
@gabe-l-hart
Copy link
Collaborator

Also, thanks @gkumbhat for solving the same problem in #12! Human race conditions at work

@viveknshah viveknshah deleted the INTRO_UINT64 branch November 1, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Add support for int64
2 participants