Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Introduce support for Int64 and UInt64 for protobuf #12

Closed
wants to merge 10 commits into from

Conversation

viveknshah
Copy link
Contributor

Fixes #11

Verified Tests locally:

image

@viveknshah
Copy link
Contributor Author

@gabe-l-hart Not quite sure but I figured this was the expected outcome of the issue? Let me know if I misunderstood.

Copy link
Collaborator

@gabe-l-hart gabe-l-hart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @viveknshah! Minor NIT on the spacing which you can fix by running make fmt in the base of the repo. Also, IBM's org enforces signed commits, so you can do the following to sign: git fetch origin && git rebase origin/main --signoff.

Finally, it would be great to add a quick unit test to explicitly verify that the new types are supported. We've still got 100% coverage as is since the dict is declared, but it would be great to ensure that nothing breaks in the JTD validation. The test would look a lot like this one.

jtd_to_proto/jtd_to_proto.py Outdated Show resolved Hide resolved
Signed-off-by: viveknshah <vivek_n_shah@yahoo.com>
Signed-off-by: viveknshah <vivek_n_shah@yahoo.com>
@viveknshah
Copy link
Contributor Author

Thanks for the contribution @viveknshah! Minor NIT on the spacing which you can fix by running make fmt in the base of the repo. Also, IBM's org enforces signed commits, so you can do the following to sign: git fetch origin && git rebase origin/main --signoff.

Finally, it would be great to add a quick unit test to explicitly verify that the new types are supported. We've still got 100% coverage as is since the dict is declared, but it would be great to ensure that nothing breaks in the JTD validation. The test would look a lot like this one.

Thank you for your patient feedback. Have made the appropriate formating flows, verified the added tests and followed the signed commit command.

Signed-off-by: viveknshah <vivek_n_shah@yahoo.com>
Signed-off-by: viveknshah <vivek_n_shah@yahoo.com>
Signed-off-by: viveknshah <vivek_n_shah@yahoo.com>
Signed-off-by: viveknshah <vivek_n_shah@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Add support for int64
2 participants