Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lz4 compression #256

Closed
eapache opened this issue Feb 10, 2015 · 8 comments
Closed

Support lz4 compression #256

eapache opened this issue Feb 10, 2015 · 8 comments

Comments

@eapache
Copy link
Contributor

eapache commented Feb 10, 2015

https://github.com/cloudflare/golz4 should be simple enough

https://issues.apache.org/jira/browse/KAFKA-1456
https://issues.apache.org/jira/browse/KAFKA-1493

@eapache
Copy link
Contributor Author

eapache commented Feb 17, 2015

And yet as with snappy, the framing format kafka uses is not supported by the "normal" go lz4 package.

http://fastcompression.blogspot.ca/2013/04/lz4-streaming-format-final.html

@edenhill
Copy link

Again? That's annoying...

@eapache
Copy link
Contributor Author

eapache commented Jun 10, 2016

This is still not documented on the official protocol page, we don't need it, and nobody else seems to be asking for it. I'm gonna icebox this until somebody actually wants it.

@eapache eapache closed this as completed Jun 10, 2016
@cdstelly
Copy link

Kafka v 0.10 supports LZ4 with correct offsets:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-57+-+Interoperable+LZ4+Framing
https://issues.apache.org/jira/browse/KAFKA-3160

Can this be reopened?

@eapache
Copy link
Contributor Author

eapache commented Oct 14, 2016

I'll re-open, but I don't have any time to implement this in the next little while so it won't mean much.

@eapache eapache reopened this Oct 14, 2016
@rtreffer
Copy link
Contributor

See #786

@rtreffer
Copy link
Contributor

@eapache I guess this can be closed. I tried the LZ4 on our 0.10.0.1 cluster. It didn't outperform GZIP for our usecase but it works.

@eapache
Copy link
Contributor Author

eapache commented Nov 24, 2016

Yup, thanks. If anybody really wants the weird framing support then that can be another ticket but I doubt anyone cares.

@eapache eapache closed this as completed Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants