Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Formats do support different target_prefix in demos #1006

Closed
yoavkatz opened this issue Jul 9, 2024 · 3 comments
Closed

Current Formats do support different target_prefix in demos #1006

yoavkatz opened this issue Jul 9, 2024 · 3 comments
Assignees

Comments

@yoavkatz
Copy link
Member

yoavkatz commented Jul 9, 2024

Today the code in formats.py assumes the target prefix for the demos is taken from the instance. This may cause subtle issue when the target_prefix uses input field for formatting (e.g. target_prefix="The answer for {num1} + {num2} is")

@elronbandel
Copy link
Member

can you explain why it causes issue in that case? or in what cases it will fail?

@yoavkatz
Copy link
Member Author

yoavkatz commented Jul 9, 2024

Since we take the target_prefix from the main instance and not the demos, if the instance is verbalized the calculation of 1+2 and the demo need to verbalize 4+5, it will use the instance target_prefix verbalization in the demos:

User: calculate 4+5?
Assistant: The answer of 1+2 is 9 <--- demo (note the wrong target_prefix)

User: calculate 1+2?
Assistant: The answer of 1+2 is

@dafnapension
Copy link
Collaborator

Resolved by PR #1031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants