Merge pull request #1805 from IBMa/tile-clickthrough

fix(extension): Tile clickthrough and splash at change url
IBMa · Jan 18, 2024 · 6434d65 · 6434d65
2 parents ea820c6 + abb839a
commit 6434d65
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/accessibility-checker-extension/src/ts/devtools/components/reportTreeGrid.tsx b/accessibility-checker-extension/src/ts/devtools/components/reportTreeGrid.tsx
@@ -837,6 +837,7 @@ export class ReportTreeGrid<RowType extends IRowGroup> extends React.Component<R
                                             // tabIndex={focused ? 0 : -1}
                                             onClick={() => {
                                                 this.onRow(group, thisIssue);
+                                                ReportTreeGrid.devtoolsAppController.setSecondaryView("help");
                                                 ReportTreeGrid.devtoolsAppController.openSecondary(`#${rowId} a`);
                                             }}
                                             // onKeyDown={(evt: React.KeyboardEvent) => {

diff --git a/accessibility-checker-extension/src/ts/devtools/devtoolsAppController.ts b/accessibility-checker-extension/src/ts/devtools/devtoolsAppController.ts
@@ -14,7 +14,7 @@
   limitations under the License.
 *****************************************************************************/
 
-import { eFilterLevel } from "../interfaces/interfaces";
+import { IReport, eFilterLevel } from "../interfaces/interfaces";
 import { getDevtoolsController } from "./devtoolsController";
 
 export type eSecondaryView = "splash" | "summary" | "stored" | "help" | "kcm_overview" | "checkerViewAware";
@@ -48,8 +48,15 @@ export class DevtoolsAppController {
 
     constructor() {
         getDevtoolsController().addSelectedIssueListener(async () => {
-            this.setSecondaryView("help");
+            if (!this.secondaryOpen) {
+                this.setSecondaryView("help");
+            }
         });
+        getDevtoolsController().addReportListener(async (report: IReport) => {
+            if (!report) {
+                this.setSecondaryView("splash");
+            }
+        })
     }
 
     ///////////////////////////////////////////////////////////////////////////