Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): fix mapping issue when multiple reason codes are available #1745

Merged
merged 10 commits into from
Dec 12, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Nov 13, 2023

sync dev branch dev-1674 with dev-1731

  • Rule bug: target_spacinf_sufficient

This PR is related to the following issue(s):

#1731

Testing reference:

  1. select "WCAG_2_2" ruleset.
  2. run the following test case: test/v2/checker/accessibility/rules/target_spacing_sufficient_ruleunit/element_target.html
  3. You should see the level of the following message is changed from "Recommendation" to "Violation":
    'Undersized target "button" does not have sufficient spacing of 12 CSS pixels from another target "button"'

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@ErickRenteria ErickRenteria merged commit 3788a6b into master Dec 12, 2023
15 checks passed
@tombrunet tombrunet deleted the dev-1731 branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants