feature(extension): Add issue ignore (hide / show) functionality to checker #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombrunet
previously approved these changes
Nov 21, 2023
tombrunet
reviewed
Dec 12, 2023
| @@ -81,6 +82,7 @@ export class ReportRules extends React.Component<ReportProps> { | |||
| group.children.sort((a, b) => UtilIssue.valueToOrder(a.value)-UtilIssue.valueToOrder(b.value)); | |||
| } | |||
| } | |||
| console.log("rowData = ",rowData); | |||
There was a problem hiding this comment.
Suggested change
| console.log("rowData = ",rowData); |
tombrunet
requested changes
Dec 12, 2023
| @@ -845,6 +861,7 @@ export class ReportTreeGrid<RowType extends IRowGroup> extends React.Component<R | |||
| ReportTreeGrid.bgcontroller.setIgnore(url, this.state.checkedIssues, ignoreAction !== "Show"); | |||
| this.setState({checkedIssues: []}); | |||
| this.props.onFilterToolbar(true); | |||
| this.props.onResetFilters(); | |||
There was a problem hiding this comment.
I don't think we want to do this
tombrunet
previously approved these changes
Dec 12, 2023
…ual-access into joho-updateHeaderUI-1664
|
Ready for review. Show / hide regular, Keyboard mode, and Summary. |
tombrunet
previously approved these changes
Jan 4, 2024
|
@ErickRenteria you can do the review all I did was comment out some content that Design did not want. |
|
Tested on Chrome, FF, and Edge browser in the macOS. No major issue found |
ErickRenteria
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
#936
#1664
#1666
#1667
#1685
Additional information can be found here:
Testing reference:
See Design Document
https://www.figma.com/file/intddqthciXilHQCLWppQ7/a11y-checker?type=design&node-id=428-78341&mode=design&t=8pT6zTqUoUWAUIDh-0
I have conducted the following for this PR: