-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(extension): Add issue ignore (hide / show) functionality to checker #1749
Conversation
@@ -81,6 +82,7 @@ export class ReportRules extends React.Component<ReportProps> { | |||
group.children.sort((a, b) => UtilIssue.valueToOrder(a.value)-UtilIssue.valueToOrder(b.value)); | |||
} | |||
} | |||
console.log("rowData = ",rowData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log("rowData = ",rowData); |
@@ -845,6 +861,7 @@ export class ReportTreeGrid<RowType extends IRowGroup> extends React.Component<R | |||
ReportTreeGrid.bgcontroller.setIgnore(url, this.state.checkedIssues, ignoreAction !== "Show"); | |||
this.setState({checkedIssues: []}); | |||
this.props.onFilterToolbar(true); | |||
this.props.onResetFilters(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to do this
…ual-access into joho-updateHeaderUI-1664
Ready for review. Show / hide regular, Keyboard mode, and Summary. |
@ErickRenteria you can do the review all I did was comment out some content that Design did not want. |
Tested on Chrome, FF, and Edge browser in the macOS. No major issue found |
This PR is related to the following issue(s):
#936
#1664
#1666
#1667
#1685
Additional information can be found here:
Testing reference:
See Design Document
https://www.figma.com/file/intddqthciXilHQCLWppQ7/a11y-checker?type=design&node-id=428-78341&mode=design&t=8pT6zTqUoUWAUIDh-0
I have conducted the following for this PR: