Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(input_label_exists) fix issue related to button element with a label #1775

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Dec 7, 2023

#761

  • Rule bug: input_label_exists

This PR is related to the following issue(s):

#761

Additional information can be found here:

Testing reference:

test case: test/v2/checker/accessibility/rules/input_label_exists_ruleunit/button_label.html
After the fix is applied, the following violations should be fixed:
Form control element has no associated label
Form control with "switch" role has no associated label

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins linked an issue Dec 14, 2023 that may be closed by this pull request
@ErickRenteria ErickRenteria merged commit 85d6d62 into master Dec 18, 2023
15 checks passed
@shunguoy shunguoy deleted the dev-761 branch January 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: input_label_exists - Button should be labellable
3 participants