Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(fieldset_legend_valid) ignore the rule if the fieldset element is hidden from an AT #1778

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jan 4, 2024

#208

  • Rule bug: fieldset_legend_valid

This PR is related to the following issue(s):

#208

Testing reference:

test case: test/v2/checker/accessibility/rules/fieldset_legend_valid_ruleunit/FieldSet-disabled.html
The following Recommendation should disappear after the fix:
"fieldset element does not have a legend".

I have conducted the following for this PR:

  • [x ] I validated this code in Chrome and FF
  • [x ] I validated this fix in my local env
  • [x ] I provided details for testing
  • This PR has been reviewed and is ready for test
  • [x ] I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fixrule(fieldset_legend_valid) ignore the rule if it's hidden from an AT fixrule(fieldset_legend_valid) ignore the rule if the fieldset element is hidden from an AT Jan 5, 2024
@shunguoy shunguoy marked this pull request as ready for review January 5, 2024 15:21
@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2024-01-10 at 2 03 57 PM

@ErickRenteria ErickRenteria merged commit 837beb9 into master Jan 10, 2024
15 checks passed
@shunguoy shunguoy deleted the dev-208 branch January 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants