Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): support CSS content-visibility style #1785

Merged
merged 11 commits into from
Jan 22, 2024
Merged

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jan 10, 2024

  • Rule bug: most of the rules related to content display

This PR is related to the following issue(s):

#1008

Additional information can be found here:

Testing reference:

Test case: test/v2/checker/accessibility/rules/heading_content_exists_ruleunit/contentvisibility-auto.html
After the fix is applied, the Recommendation "Heading element has no descriptive content" should disappear.

I have conducted the following for this PR:

  • [ x] I validated this code in Chrome and FF
  • [x ] I validated this fix in my local env
  • [x ] I provided details for testing
  • This PR has been reviewed and is ready for test
  • [x ] I understand that the title of this PR will be used for the next release notes.

tombrunet
tombrunet previously approved these changes Jan 17, 2024
@shunguoy shunguoy marked this pull request as ready for review January 17, 2024 17:32
@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria added this pull request to the merge queue Jan 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@ErickRenteria ErickRenteria added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit 3044945 Jan 22, 2024
29 of 30 checks passed
@shunguoy shunguoy deleted the dev-1008 branch January 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants