fixrule(aria_keyboard_handler_exists, widget_tabbable_exists): Reduce "Needs review" issues for nested composite widgets
#1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombrunet
approved these changes
Feb 14, 2024
philljenkins
changed the title
aria_keyboard_handler_exists, widget_tabbable_exists) fix the issues related to nested composite widgetsaria_keyboard_handler_exists, widget_tabbable_exists): Reduce "Needs review" issues related to nested composite widgets
philljenkins
changed the title
aria_keyboard_handler_exists, widget_tabbable_exists): Reduce "Needs review" issues related to nested composite widgetsaria_keyboard_handler_exists, widget_tabbable_exists): Reduce "Needs review" issues related to nested composite widgets
|
@shunguoy Using the testcase url and the filter needs review under requirements the 4 2.1.1 is not being trigger. |
|
Validated |
philljenkins
changed the title
aria_keyboard_handler_exists, widget_tabbable_exists): Reduce "Needs review" issues related to nested composite widgetsaria_keyboard_handler_exists, widget_tabbable_exists): Reduce "Needs review" issues for nested composite widgets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
#1606 #1648
Additional information can be found here:
Testing reference:
test case: https://cloud.ibm.com/
Use the extension filters: Requirements and "Needs Review" only
without the fix: 2.1.1 Keyboard: 13 with "Needs Review" with the "Verify the ul element with 'menubar' role has keyboard access".
2.4.3 Focus Order: 10 with "Needs Review" with the "Component with 'menu' role does not have a tabbable element ".
After the fix: 2.1.1 Keyboard: 4 with "Needs Review" with the same message.
2.4.3 Focus Order: 7 with "Needs Review" with the same message.
I have conducted the following for this PR: